RE: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

[Anil Gurumurthy]

You could remove the __bfa_trc32() routine

Thanks,
Acked-by: Anil Gurumurthy <anil.gurumurthy@xxxxxxxxxx>

-----Original Message-----
From: Martin K. Petersen [mailto:martin.petersen@xxxxxxxxxx] 
Sent: 10 February 2016 22:59
To: Denys Vlasenko <dvlasenk@xxxxxxxxxx>
Cc: James Bottomley <JBottomley@xxxxxxxxxxxxx>; Fabian Frederick <fabf@xxxxxxxxx>; Anil Gurumurthy <Anil.Gurumurthy@xxxxxxxxxx>; Christoph Hellwig <hch@xxxxxx>; Guenter Roeck <linux@xxxxxxxxxxxx>; Ben Hutchings <ben@xxxxxxxxxxxxxxx>; linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>; linux-scsi <linux-scsi@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

>>>>> "Denys" == Denys Vlasenko <dvlasenk@xxxxxxxxxx> writes:

Denys> __bfa_trc32() is very similar, so it is uninlined too.  However, 
Denys> it appears to be unused, therefore this patch ifdefs it out.

Why don't we just drop it?

-- 
Martin K. Petersen	Oracle Linux Engineering