Re: [PATCH 1/2] sched/deadline: add per rq tracking of admitted bandwidth

From: Steven Rostedt
Date: Thu Feb 11 2016 - 09:25:54 EST


On Thu, 11 Feb 2016 14:05:45 +0100
luca abeni <luca.abeni@xxxxxxxx> wrote:


> Well, I never used the rq utilization to re-build the root_domain
> utilization (and I never played with root domains too much... :)...
> So, I do not really know. Maybe the code should do:
> raw_spin_lock(&rq->lock);
> raw_spin_lock(&cpu_rq(cpu)->lock);

Of course you want to use double_rq_lock() here instead.

-- Steve

> sub_rq_bw(&p->dl, &rq->dl);
> add_rq_bw(&p->dl, &cpu_rq(cpu)->dl);
> [...]
> ?
>
>
> Luca