Re: [PATCH] MIPS: tlb-r4k: panic if the MMU doesn't support PAGE_SIZE

From: Maciej W. Rozycki
Date: Thu Feb 11 2016 - 14:37:22 EST


On Wed, 10 Feb 2016, Paul Burton wrote:

> > diff --git a/arch/mips/mm/tlb-r4k.c b/arch/mips/mm/tlb-r4k.c
> > index 08318ec..4330315 100644
> > --- a/arch/mips/mm/tlb-r4k.c
> > +++ b/arch/mips/mm/tlb-r4k.c
> > @@ -486,6 +487,10 @@ static void r4k_tlb_configure(void)
> > * be set to fixed-size pages.
> > */
> > write_c0_pagemask(PM_DEFAULT_MASK);
> > + back_to_back_c0_hazard();
> > + if (read_c0_pagemask() != PM_DEFAULT_MASK)
> > + panic("MMU doesn't support PAGE_SIZE=0x%lx", PAGE_SIZE);

I think it would make sense to report here what the minimum/maximum page
size actually supported is, so that the users know what there might be
after.

Maciej