Re: [PATCH 3/3] net: mvpp2: Return correct error codes

From: David Miller
Date: Sat Feb 13 2016 - 05:59:08 EST


From: Amitoj Kaur Chawla <amitoj1606@xxxxxxxxx>
Date: Thu, 4 Feb 2016 19:25:26 +0530

> The return value of kzalloc on failure of allocation of memory should
> be -ENOMEM and not -1.
>
> Found using Coccinelle. A simplified version of the semantic patch
> used is:
...
> This function may also return -1 after calling mpp2_prs_tcam_port_map_get.
> So that the function consistently returns meaningful error values on
> failure, the -1 is changed to -EINVAL.
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@xxxxxxxxx>

Applied.