Re: [PATCH] net: cavium: liquidio: fix check for in progress flag

[David Miller]

From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Fri,  5 Feb 2016 16:30:39 +0000

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> smatch detected a suspicious looking bitop condition:
> 
> drivers/net/ethernet/cavium/liquidio/lio_main.c:2529
>   handle_timestamp() warn: suspicious bitop condition
> 
> (skb_shinfo(skb)->tx_flags | SKBTX_IN_PROGRESS is always non-zero,
> so the logic is definitely not correct.  Use & to mask the correct
> bit.
> 
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied, thanks.

But this means one of the code paths was never tested...