Re: [PATCH 3/9] cpufreq: governor: Fix nice contribution computation in dbs_check_cpu()

From: Viresh Kumar
Date: Mon Feb 15 2016 - 03:29:26 EST


On 15-02-16, 02:15, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> The contribution of the CPU nice time to the idle time in dbs_check_cpu()
> is computed in a bogus way, as the code may subtract current and previous
> nice values for different CPUs.
>
> That doesn't matter for cases when cpufreq policies are not shared,
> but may lead to problems otherwise.
>
> Fix the computation and simplify it to avoid taking unnecessary steps.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> ---
> drivers/cpufreq/cpufreq_governor.c | 18 +++---------------
> 1 file changed, 3 insertions(+), 15 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh