Re: [PATCH 3/3] spi: rockchip: add debug interface support

[Shawn Lin]

Hi Mark,

On 2016/2/16 1:26, Mark Brown wrote:
> On Mon, Feb 15, 2016 at 04:28:22PM +0800, Shawn Lin wrote:
>
> > +#ifdef CONFIG_DEBUG_FS
> > +#include <linux/debugfs.h>
> > +#endif
>
> Just include the header.  Only add ifdefs if they do something.
>
> > +static int rockchip_spi_debugfs_init(struct rockchip_spi *rs)
> > +{
> > +	rs->debugfs = debugfs_create_dir("rockchip_spi", NULL);
> > +	if (!rs->debugfs)
> > +		return -ENOMEM;
> > +
> > +	debugfs_create_file("regs", S_IFREG | S_IRUGO,
> > +		rs->debugfs, (void *)rs, &rockchip_spi_dbg_ops);
> > +	return 0;
> > +}
>
> This is completely separate to the core debugfs support for SPI, if
> we're adding new debugfs stuff that's per device we should be extending
> the core debugfs stuff so everything is in one place.

yes, I will check the spi core debugfs to see how we can extend it
for per device to dump specific msg.

Thanks.

> Your register dump stuff looks like you might want to consider using
> regmap, it's got this and other register access diagnostics already.


--
Best Regards
Shawn Lin