Re: [PATCH 2/3] coccinelle: recognize more devm_* memory allocation functions

From: Julia Lawall
Date: Tue Feb 16 2016 - 12:18:55 EST



On Tue, 16 Feb 2016, Yann Droneaud wrote:

> Updates free/devm_free.cocci to recognize functions added by:
>
> - commit 64c862a839a8 ('devres: add kernel standard devm_k.alloc functions')
> - commit e31108cad3de ('devres: introduce API "devm_kstrdup"')
> - commit 3046365bb470 ('devres: introduce API "devm_kmemdup')
> - commit 43339bed7010 ('devres: Add devm_get_free_pages API')
> - commit 75f2a4ead5d5 ('devres: Add devm_kasprintf and devm_kvasprintf API')
>
> See also Documentation/driver-model/devres.txt
>
> Cc: Joe Perches <joe@xxxxxxxxxxx>
> Cc: Manish Badarkhe <badarkhe.manish@xxxxxxxxx>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> Cc: Eli Billauer <eli.billauer@xxxxxxxxx>
> Cc: Himangi Saraogi <himangi774@xxxxxxxxx>
> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Cc: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> Cc: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> Signed-off-by: Yann Droneaud <ydroneaud@xxxxxxxxxx>

Acked-by: Julia Lawall <julia.lawall@xxxxxxx>

> ---
> scripts/coccinelle/free/devm_free.cocci | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/scripts/coccinelle/free/devm_free.cocci b/scripts/coccinelle/free/devm_free.cocci
> index 83c03adec1c5..3794cd97494b 100644
> --- a/scripts/coccinelle/free/devm_free.cocci
> +++ b/scripts/coccinelle/free/devm_free.cocci
> @@ -29,8 +29,24 @@ expression x;
> @@
>
> (
> + x = devm_kmalloc(...)
> +|
> + x = devm_kvasprintf(...)
> +|
> + x = devm_kasprintf(...)
> +|
> x = devm_kzalloc(...)
> |
> + x = devm_kmalloc_array(...)
> +|
> + x = devm_kcalloc(...)
> +|
> + x = devm_kstrdup(...)
> +|
> + x = devm_kmemdup(...)
> +|
> + x = devm_get_free_pages(...)
> +|
> x = devm_request_irq(...)
> |
> x = devm_ioremap(...)
> @@ -50,6 +66,10 @@ position p;
> |
> * kzfree@p(x)
> |
> +* free_pages@p(x, ...)
> +|
> +* free_page@p(x)
> +|
> * free_irq@p(x)
> |
> * iounmap@p(x)
> --
> 2.5.0
>
>