Re: [PATCH] kernel/hung_task.c: printk address for hung_task

From: Kassey
Date: Wed Feb 17 2016 - 02:17:16 EST


Ingo, Mandeep:
can you review this patch ?
BR
Kassey

On Thu, Jan 14, 2016 at 5:33 PM, Kassey <kassey1216@xxxxxxxxx> wrote:
> Xinhui:
> when I got a DDR dump, with the task_struct address for this
> task, I can see what file this task is accessing, as well as
> task_struct member.
> this is very useful and popular on arch where we can generate a
> DDR dump when system crash.
>
> BR
> Kassey
>
> On Thu, Jan 14, 2016 at 10:45 AM, Pan Xinhui <xinhui@xxxxxxxxxxxxxxxxxx> wrote:
>> hi, Li
>> I have a little confusion. for what you want to know this ptr's value. Can that help you debug or root the cause?
>> I'm just wondering :)
>>
>> thanks
>> xinhui
>>
>> On 2016å01æ13æ 10:42, Li wrote:
>>> From: Kassey Li <kassey1216@xxxxxxxxx>
>>>
>>> this is used to check task_struct info when got a dump.
>>>
>>> Signed-off-by: Kassey Li <kassey1216@xxxxxxxxx>
>>> ---
>>> kernel/hung_task.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/kernel/hung_task.c b/kernel/hung_task.c
>>> index d234022..b5dd7dd 100644
>>> --- a/kernel/hung_task.c
>>> +++ b/kernel/hung_task.c
>>> @@ -108,8 +108,8 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)
>>> * Ok, the task did not get scheduled for more than 2 minutes,
>>> * complain:
>>> */
>>> - pr_err("INFO: task %s:%d blocked for more than %ld seconds.\n",
>>> - t->comm, t->pid, timeout);
>>> + pr_err("INFO: task %s:%d 0x%p blocked for more than %ld seconds.\n",
>>> + t->comm, t->pid, t, timeout);
>>> pr_err(" %s %s %.*s\n",
>>> print_tainted(), init_utsname()->release,
>>> (int)strcspn(init_utsname()->version, " "),
>>>
>>
>
>
>
> --
> Best regards
> Kassey



--
Best regards
Kassey