Re: [PATCH 2/4] mfd: max77686: Use module_i2c_driver() instead of subsys initcall

[Javier Martinez Canillas]

Hello Krzysztof,

On 02/17/2016 04:49 AM, Krzysztof Kozlowski wrote:
> On 17.02.2016 05:45, Javier Martinez Canillas wrote:

[snip]

> > > By "please check" in this case I mean - look if every regulator/clock
> > > consumer using stuff exposed by PMIC, supports properly deferred probing.
> >
> > Got it, I checked and all but one consumer driver that use resources
> > provided by the max77686 defer probe when this is not found AFAICT.
> >
> > Clocks:
> >
> > drivers/mmc/core/pwrseq_simple.c
> > drivers/rtc/rtc-s3c.c
> >
> > Regulators:
> >
> > drivers/cpufreq/cpufreq-dt.c
> > drivers/gpu/drm/exynos/exynos_drm_dsi.c
> > drivers/gpu/drm/exynos/exynos_hdmi.c
> > drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c
> > drivers/iio/adc/exynos_adc.c
> > drivers/input/misc/max77693-haptic.c
> > drivers/input/touchscreen/mms114.c
> > drivers/media/i2c/s5c73m3/s5c73m3-core.c
> > drivers/media/i2c/s5k6a3.c
> > drivers/media/platform/exynos4-is/mipi-csis.c
> > drivers/mfd/wm8994-core.c
> > drivers/mmc/host/dw_mmc.c
> > drivers/mmc/host/sdhci.c
> > drivers/usb/dwc2/platform.c
> >
> > The only driver that does not defer probe when an input supply
> > isn't found is drivers/thermal/samsung/exynos_tmu.c (vtmu-supply).
> >
> > So that should be handled before this series are merged.
>
> Thanks for the analysis. Indeed the exynos_tmu does not support probe
> deferral. Instead it just ignores the error and skips the regulator. It
> would be good to fix this before applying this patch.

Ok. I'll take care of that, probably tomorrow.
 
> Rest looks indeed good so I don't have objections (beside tmu case).

Thanks a lot for your feedback and suggestions.

> Best regards,
> Krzysztof
> --

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America