Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu lookups

From: Thomas Gleixner
Date: Wed Feb 17 2016 - 14:11:12 EST


On Wed, 17 Feb 2016, Vikas Shivappa wrote:

Please stop top posting, finally!

> But we have an extra static - static to avoid having it in the stack..

It's not about the cpu mask on the stack. The reason was that with cpumask off
stack cpumask_and_mask() requires an allocation, which then can't be used in
the starting/dying callbacks.

Darn, you are right to remind me.

Now, the proper solution for this stuff is to provide a library function as we
need that for several drivers. No point to duplicate that functionality. I'll
cook something up and repost the uncore/cqm set tomorrow.

Thanks,

tglx