Re: [PATCH 2/2] net, thunderx: Use bool in structs where possible

From: David Miller
Date: Thu Feb 18 2016 - 15:06:37 EST


From: Robert Richter <robert.richter@xxxxxxxxxxxxxxxxxx>
Date: Thu, 18 Feb 2016 17:42:17 +0100

> On 18.02.16 11:05:14, David Miller wrote:
>> From: Robert Richter <rrichter@xxxxxxxxxxxxxxxxxx>
>> Date: Thu, 18 Feb 2016 13:39:09 +0100
>>
>> > From: Robert Richter <rrichter@xxxxxxxxxx>
>> >
>> > Looks like the :1 notation was accidentally introduced (this still
>> > uses 1 byte per flag). Using bool instead, which is the common use.
>> >
>> > Signed-off-by: Robert Richter <rrichter@xxxxxxxxxx>
>>
>> Such cleanups are not appropriate for 'net'. Only real bug fixes should
>> be targetted that.
>>
>> Respin these patches targetting the correct tree(s).
>
> Do you mean posting the two as "trivial" patches?

No I mean posting #1 targetted at my 'net' GIT tree as a bug fix,
and posting #2 targetted separately at my 'net-next' GIT tree as
a cleanup.

This is how we've been doing things for more than a decade.