Re: [PATCH v4 1/2] usb: musb: Fix DMA for host mode

[Sergei Shtylyov]

Hello.

On 02/19/2016 07:41 PM, Joshua Henderson wrote:

> From: Cristian Birsan <cristian.birsan@xxxxxxxxxxxxx>
>
> Commit ac33cdb16681 ("usb: musb: Remove ifdefs for musb_host_rx in
> musb_host.c part5") introduces a problem setting DMA host mode.
>
> This commit fixes the done condition that advances the musb schedule.
> Without this patch the the msub_advance_schedule() is called immediately
> after receiving an endpoint RX interrupt without waiting for the DMA
> transfer to complete. As a consequence when the dma complete interrupt
> arrives the in_qh member of hw_ep is already null an the musb_host_rx()
> exits on !urb error case.
>
> Signed-off-by: Cristian Birsan <cristian.birsan@xxxxxxxxxxxxx>
> Signed-off-by: Joshua Henderson <joshua.henderson@xxxxxxxxxxxxx>
> Tested-by: Ladislav Michl <ladis@xxxxxxxxxxxxxx>

Acked-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>

   Although you didn't describe your changes to the original patch in the 
change log...

MBR, Sergei