Re: [PATCH] omap3: Add cpuidle parameters table for omap3430

From: Tony Lindgren
Date: Fri Feb 19 2016 - 13:36:55 EST


* Tony Lindgren <tony@xxxxxxxxxxx> [160216 08:11]:
> * Pali RohÃr <pali.rohar@xxxxxxxxx> [160216 02:09]:
> > On Tuesday 16 February 2016 11:01:43 Daniel Lezcano wrote:
> > > On 02/15/2016 07:02 PM, Pali RohÃr wrote:
> > > >Based on CPU type choose generic omap3 or omap3430 specific cpuidle
> > > >parameters. Parameters for omap3430 were measured on Nokia N900 device and
> > > >added by commit 5a1b1d3a9efa ("OMAP3: RX-51: Pass cpu idle parameters")
> > > >which were later removed by commit 231900afba52 ("ARM: OMAP3: cpuidle -
> > > >remove rx51 cpuidle parameters table") due to huge code complexity.
> > > >
> > > >This patch brings cpuidle parameters for omap3430 devices again, but uses
> > > >simple condition based on CPU type.
> > > >
> > > >Signed-off-by: Pali RohÃr <pali.rohar@xxxxxxxxx>
> > > >Fixes: 231900afba52d6faddfb480cde4132d4edc089bc
> > > >---
> > >
> > > Acked-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> >
> > Tony, Nishanth (or somebody else...) can you test this patch on more
> > omap3 devices to check if it does not break existing cpuidle code?
>
> Seems to work for me on a ldp, which is GP 3430 ES3.0.

OK applying this into omap-for-v4.6/fixes-not-urgent considering
we've already lived with it for years.

Regards,

Tony