Re: [PATCH v3] mptbase: fixup error handling paths in mpt_attach()

From: Johannes Thumshirn
Date: Tue Feb 23 2016 - 09:29:23 EST


On Tue, Feb 23, 2016 at 09:00:12AM -0500, Ewan D. Milne wrote:
> From: "Ewan D. Milne" <emilne@xxxxxxxxxx>
>
> mpt_attach() was not checking for the failure to create fw_event_q.
> Also, iounmap() was not being called in all error cases after ioremap()
> had been called by mpt_mapresources().
>
> Reported-by: Insu Yun <wuninsu@xxxxxxxxx>
> Reviewed-by: Tomas Henzl <thenzl@xxxxxxxxxx>
> Signed-off-by: Ewan D. Milne <emilne@xxxxxxxxxx>

Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>

--
Johannes Thumshirn Storage
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850