Re: [PATCH] ASoC: arizona: Make logging of FLL calculations clearer

From: Richard Fitzgerald
Date: Wed Feb 24 2016 - 12:39:48 EST

On 24/02/16 04:08, Mark Brown wrote:
On Tue, Feb 23, 2016 at 02:16:32PM +0000, Richard Fitzgerald wrote:
The debug logging of FLL calculations was confusing. Values were
printed in hex without indicating this by a leading 0x, and
despite these normally being required in decimal. Also where the
register value isn't the actual value (it s a power-of-two or
0 means 1, 1 means 2, ...) it was unclear whether the actual or
register value was shown.
I think that stuff was originally based on the way the datasheets quote

- arizona_fll_dbg(fll, "FRATIO=%x(%d) OUTDIV=%x REFCLK_DIV=%x\n",
the hex(decimal) but there is certainly very familiar from some of
Indeed, and it was fine on the first codec. Now we've got various revisions of the FLL with some fields having different meanings, human error started to creep into interpreting the debug.