On Tue, Feb 23, 2016 at 04:56:38PM -0600, Aravind Gopalakrishnan wrote:
I think MSR_AMD64_SMCA_MC0_MISC0 would be required in mce.c as well.Actually, I'm thinking, these all are - even if used in multiple files
So might be better to retain it here.
- all MCE-specific and therefore used in MCE/RAS-specific code. So they
all should go into mce.h. Everything RAS includes that header so they're
perfectly fine there...
(It comes up to 81 chars, but will ignore checkpatch in this case..)The 80-cols rule is not a hard one. Here's some food for thought: