Re: [PATCH 2/4] x86/mce/AMD: Fix logic to obtain block address

From: Aravind Gopalakrishnan
Date: Wed Feb 24 2016 - 13:03:05 EST

On 2/24/2016 5:33 AM, Borislav Petkov wrote:
On Tue, Feb 23, 2016 at 04:56:38PM -0600, Aravind Gopalakrishnan wrote:
I think MSR_AMD64_SMCA_MC0_MISC0 would be required in mce.c as well.
So might be better to retain it here.
Actually, I'm thinking, these all are - even if used in multiple files
- all MCE-specific and therefore used in MCE/RAS-specific code. So they
all should go into mce.h. Everything RAS includes that header so they're
perfectly fine there...

Hmm. We introduced MSR_AMD64_SMCA_MCx_CONFIG in this patch-

Should I change that as well and move it to mce.h?

(It comes up to 81 chars, but will ignore checkpatch in this case..)
The 80-cols rule is not a hard one. Here's some food for thought:

Got it.