Re: [PATCH v2 0/3] drm: introduce bus_flags for pixel clock polarity
From: Stefan Agner
Date: Wed Feb 24 2016 - 14:12:41 EST
On 2016-02-24 03:06, Tomi Valkeinen wrote:
> On 24/02/16 01:30, Stefan Agner wrote:
>> Any comments on this?
>> Also added Manfred, Tomi and Boris to CC which previously attended in
>> similar discussions.
>> Previous discussions:
>> I think one of the main observation so far was that the pixel clock
>> polarity is not a property of the mode, and therefor does not fit into
>> the DRM_MODE_FLAG. This has been pointed out nicely by Russel:
>> Embedded displays connected through parallel bus make use of the
>> bus_formats field in drm_display_mode. This field defines what kind of
>> bus format the display requires. This patch follows that idea and adds
>> bus_flags. bus_flags can be used to define specific bus properties
>> required by the display, such as pixel clock or data enable polarity...
> I think it would be good to split the generic and fsl changes to
> separate patches.
I guess we talk about PATCH 3/3?
This is intentionally in one patch: The problem is that the current
default setting of the driver is the correct setting for that one NEC
display. The patch changes the default setting of the display controller
driver, but to make sure the NEC display continues to work I need to add
the polarity flag to the display. Therefor I feel this is one logical
change... Also this way the display keeps working between every commit
The core changes (the flag defines and adding the field to struct
drm_display_info) are in a separate patch.
> I agree that pixel clock polarity shouldn't be visible to userspace.
> I had a look at MIPI DPI spec, and it says "The rising edge of PCLK is
> used by the display module to capture pixel data.". So, I think that
> means if the panels are MIPI DPI compatible, they should always sample
> at rising edge. I'm sure there are exceptions, but that behaviour should
> probably be the default, then.
Yes, that is the new default of the driver.
> I'm also a bit curious on what is "videomode". Why is sync polarity part
> of it, and settable by the userspace, but not pixel clock polarity?
> "videomode" is just whatever is in the CEA spec, because DRM originates
> from the PC world? Is there any reason nowadays for the user to ever set
> sync polarities?
> For MIPI DPI panels, sync polarity is as much a property of the panel as
> pixel clock polarity: there's only one correct setting for it (usually).
We probably could add the sync properties to the bus_flags too, and
those would take precedence over the mode sync polarities...? Certainly
something which could be done in a follow up patch.