Re: [PATCH 09/12] KVM: MMU: coalesce zapping page after mmu_sync_children

From: Paolo Bonzini
Date: Thu Feb 25 2016 - 03:49:15 EST




On 25/02/2016 08:35, Xiao Guangrong wrote:
>> This may release the mmu_lock before committing the zapping.
>> Is it safe? If so, we may want to see the reason in the changelog.
>
> It is unsafe indeed, please do not do it.

Can you explain why? kvm_zap_obsolete_pages does the same.

Paolo