Re: [PATCH v3 6/8] arm64: dts: qcom: fix usb digital voltage levels

From: Srinivas Kandagatla
Date: Thu Feb 25 2016 - 06:22:12 EST

On 24/02/16 23:06, Stephen Boyd wrote:
On 02/23/2016 08:50 AM, Srinivas Kandagatla wrote:
This patch updates the digital voltage levels from corner values to
microvolts as we are going to use s1 regulator directly for vddcx
instead of s1_corner.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>

What's the plan for corners? Maybe we should remove the voltage setting
from the usb driver or drop the usb node entirely on msm8916 until we
resolve how we're going to handle corners. I'd like to avoid getting
stuck into some DT binding ABI mess here.

Andy/Bjorn, any comments on plans on corner regulators?

Please note, that this is a patch to fix what is already in the mainline. Without this patch the regulator would be configured with 1uV or 5uV or 7uV which would obviously fail.

THB, it does not make sense to drop feature which is functional, and I also agree that we should cleanup some of this mess at some point in time once we all the bits and pieces ready.

I was surprised to see these usb bindings(qcom,vdd-levels) existed even before we had concept of corner regulators in mainline kernel. Which also suggests that this driver needs a proper relook once again.