Re: [PATCHv6 1/3] rdmacg: Added rdma cgroup controller
From: Haggai Eran
Date: Thu Feb 25 2016 - 09:42:22 EST
On 25/02/2016 16:26, Parav Pandit wrote:
>> Can we call kfree() with spin_lock held? All these years I tend to
>> avoid doing so.
> Also it doesn't look correct to hold the lock while freeing the memory
> which is totally unrelated to the lock.
> With that I think current code appears ok with exception that its
> duplicated at two place for code readability around lock.
> What say?
Yes, the only thing that bothered me there was the duplication.