Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles
From: Jiri Kosina
Date: Thu Feb 25 2016 - 10:13:09 EST
On Thu, 25 Feb 2016, Chen Gang wrote:
> I can understand for your NAK, it is a trivial patch.
Not all trivial patches are NAKed :) But they have to be generally useful.
Shuffling code around, without actually changing / improving it a bit,
just for the sole purpose of formatting, is kind of pointless (especially
given the fact that the current code as-is is easily readable; it's not
like it'd be a horrible mess difficult to understand).
Sure, it might had been formatted better at the time it was actually
merged. But changing it "just because" after being in tree for long time
doesn't fix any problem really.
> And excuse me, I guess my english is not quite well, I am not quite
> understand the meaning below, could you provide more details?
> "it's preferable to preserve blame than go through a layer of cleanup
> when looking for the commit that defined particular flags".
git-blame. When looking at commits touching particular lines, you add an
extra hop to the person who is trying to find a (functional) commit that
touched a particular line.