Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles
From: Mel Gorman
Date: Thu Feb 25 2016 - 11:07:19 EST
On Thu, Feb 25, 2016 at 10:38:58PM +0800, Chen Gang wrote:
> On 2/25/16 17:27, Mel Gorman wrote:
> > On Thu, Feb 25, 2016 at 06:26:31AM +0800, chengang@xxxxxxxxxxxxxxxx wrote:
> >> From: Chen Gang <chengang@xxxxxxxxxxxxxxxx>
> >> Always notice about 80 columns, and the white space near '|'.
> >> Let the wrapped function parameters align as the same styles.
> >> Remove redundant statement "enum zone_type z;" in function gfp_zone.
> >> Signed-off-by: Chen Gang <gang.chen.5i5j@xxxxxxxxx>
> > NAK from me at least. From my perspective, it's preferrable to preserve
> > blame than go through a layer of cleanup when looking for the commit
> > that defined particular flags. It's ok to cleanup code at the same time
> > definitions change for functional or performance reasons.
> I can understand for your NAK, it is a trivial patch. For me, I guess
> trivial@xxxxxxxxxx will care about this kind of patch.
I do not want this patch to go through the trivial tree. It still adds
another step to identifying relevant commits through git blame and has
limited, if any, benefit to maintainability.
> "it's preferable to preserve blame than go through a layer of cleanup
> when looking for the commit that defined particular flags".
git blame identifies what commit last altered a line. If a cleanup patch
is encountered then the tree before that commit needs to be examined
which adds time. It's rare that cleanup patches on their own are useful
and this is one of those cases.