Re: [lustre-devel] [PATCH v2 0/6] staging: lustre: update modinfo data
From: Greg Kroah-Hartman
Date: Fri Feb 26 2016 - 01:25:31 EST
On Fri, Feb 26, 2016 at 06:11:07AM +0000, Drokin, Oleg wrote:
> On Feb 26, 2016, at 1:03 AM, Greg Kroah-Hartman wrote:
> > On Thu, Feb 25, 2016 at 08:07:06PM -0500, James Simmons wrote:
> >> The module information for Lustre is stale or in some cases
> >> completely missing. This collection of patches brings the
> >> modinfo up to date as well as filling in any missing information.
> >> This patch set has been redone to rebase it on Oleg's latest
> >> patch set to avoid collisons in merging.
> >> Andreas Dilger (4):
> >> staging: lustre: add missing MODULE_AUTHOR for LNet selftest module
> >> staging: lustre: update the MODULE_DESCRIPTION for all lustre modules
> >> staging: lustre: make module_init/exit naming consistent
> >> staging: lustre: update comment for lnet_lib_init/exit
> >> James Simmons (2):
> >> staging: lustre: move module info to end of libcfs module.c file
> >> staging: lustre: update the MODULE_VERSION for all lustre modules
> > What changed to need a v2 of this series?
> > Please ALWAYS say what the difference is, don't expect us to "just
> > know".
> > Please send a v3 of this, describing the changes, in the correct format,
> > in each patch. You know better than thisâ
> I think it says above that the rebase was done on top of my patchset
> to resolve the conflict that arose?
Where? Ugh, yeah, kind of, but where is the big v2: marking or some
such thing like is required? It's very easy to miss this (as I did.)
Please make it easy for maintainers, not hard on them...