Re: [PATCH v7] mtd: nand: increase ready wait timeout and report timeouts

From: Harvey Hunt
Date: Fri Feb 26 2016 - 08:45:31 EST


On 25/02/16 23:27, Richard Weinberger wrote:
Am 26.02.2016 um 00:23 schrieb Boris Brezillon:
Regardless, this timeout loop is wrong. Shouldn't it have something like
the following?

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index f2c8ff398d6c..596a9b0503da 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -566,8 +566,8 @@ void nand_wait_ready(struct mtd_info *mtd)
} while (time_before(jiffies, timeo));

- pr_warn_ratelimited(
- "timeout while waiting for chip to become ready\n");
+ if (!chip->dev_ready(mtd))
+ pr_warn_ratelimited("timeout while waiting for chip to become ready\n");
led_trigger_event(nand_led_trigger, LED_OFF);

Looks good to me.

If you post the patch, you can add

Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>

Same here.

Reviewed-by: Richard Weinberger <richard@xxxxxx>


-cc IMG list (I left it in my gitconfig when I originally sent this patch...).

Thanks for debugging and fixing this - proposed patch looks good to me:

Reviewed-by: Harvey Hunt <harvey.hunt@xxxxxxxxxx>