Re: [PATCH v2 12/17] mm/slab: do not change cache size if debug pagealloc isn't possible
From: Joonsoo Kim
Date: Fri Feb 26 2016 - 12:02:41 EST
2016-02-27 1:13 GMT+09:00 Christoph Lameter <cl@xxxxxxxxx>:
> On Fri, 26 Feb 2016, js1304@xxxxxxxxx wrote:
>> We can fail to setup off slab in some conditions. Even in this case,
>> debug pagealloc increases cache size to PAGE_SIZE in advance and it is
>> waste because debug pagealloc cannot work for it when it isn't the off
>> slab. To improve this situation, this patch checks first that this cache
>> with increased size is suitable for off slab. It actually increases cache
>> size when it is suitable for off-slab, so possible waste is removed.
> Maybe add some explanations to the code? You tried to simplify it earlier
> and make it understandable. This makes it difficult to understand it.
There is some explanation above the changed stuff although it doesn't
appear in the patch. And, this patch doesn't change any condition for it.
What this patch does is checking if it is suitable for off slab cache
Before this patch, it is checked after increasing size and if it isn't
suitable for off slab cache, it cannot be used for debug_pagealloc with