Re: [PATCH v6] serial: support for 16550A serial ports on LP-8x4x

From: One Thousand Gnomes
Date: Mon Feb 29 2016 - 09:46:31 EST


> I haven't tested this mode. I am pretty sure it will fail. There is
> also no support for speeds higher than 115200.
>
> CS7 and CS8 at speeds up to 115200 work well.
>
> However, there is no way to report errors fromÂset_termios(). Should
> anything be done about those limitations?

You report back by setting the termios fields to the values actually
selected. Eg if you can't do CS5/CS6 you'd pick CS7 or CS8 and write that
back into tty->termios so the caller knows what they actually got. Ditto
for speed (see the 16550A core driver for the speed write backs).

Alan