Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating
From: Tony Lindgren
Date: Mon Feb 29 2016 - 17:55:45 EST
* Franklin S Cooper Jr. <fcooper@xxxxxx> [160229 14:31]:
> On 02/29/2016 04:04 PM, Tony Lindgren wrote:
> > Hmm but why are you also removing the pm_runtime calls? Those
> > actually do take care of gating the clocks via the interconnect
> > level code that is hwmod in this case.
> I removed all PM runtime calls that revolved around
> pwmss_submodule_state_change. Originally the driver would do
> a pm_runtime_get_sync then call pwmss_submodule_state_change
> and then immediately call pm_runtime_put_sync. Without
> pwmss_submodule_state_change those calls would be
> meaningless. I also removed pm_runtime calls in error paths
> that no longer existed.
Typically the interconnect level code can gate the clkctrl bit
for the module with PM runtime even with no other driver specific
registers. If you remove the pm_runtime calls, that does not
Also, how do you know this change does not affect the other
SoC variants using the same driver?