Re: [PATCH 1/2] regulator: DT: Add support to scale ramp delay based on platform behavior

From: Mark Brown
Date: Mon Feb 29 2016 - 22:09:00 EST

On Mon, Feb 29, 2016 at 09:47:51AM -0800, Bjorn Andersson wrote:
> On Mon 29 Feb 06:40 PST 2016, Laxman Dewangan wrote:

> > It is observed that voltage change in given rail affected by the load
> > and the capacitor in the rail. This may cause the slow ramp in voltage
> > against what PMIC has programmed.

> The regulator-ramp-delay is a variable you can tweak on a board basis,
> so I'm not sure what benefit it gives to be able to add a scaling
> factor to this.

> In my experience your HW engineer will say "you have to wait X ms", not
> "you have to wait 125% of X ms".

> Can you please elaborate on why the original knob isn't sufficient?

Right, this definitely feels like the wrong thing is being specified
here (and also like the PMIC might be going out of spec, possibly as a
result of being overloaded) and that the existing board specific
controls should be used. It just doesn't correspond to the way people
usually talk about specs for PMICs.

Attachment: signature.asc
Description: PGP signature