Re: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id
From: Joe Perches
Date: Tue Mar 01 2016 - 18:21:56 EST
On Tue, 2016-03-01 at 21:49 +0000, Pottratz, Dwane wrote:
> Good to know. Thx.
Andrew picked this up, but it might be better to remove your
patch and just use the --ignore option as --ignore is generic
and your patch just duplicates the capability.
>
> -----Original Message-----
> From: Joe Perches [mailto:joe@xxxxxxxxxxx] ;
> Sent: Tuesday, March 1, 2016 1:41 PM
> To: Pottratz, Dwane <dwane.pottratz@xxxxxxxxx>; apw@xxxxxxxxxxxxx; li
> nux-kernel@xxxxxxxxxxxxxxx; 'akpm@xxxxxxxxxxxxxxxxxxxx' <akpm@linux-f
> oundation.org>
> Subject: Re: [PATCH] checkpatch.pl: add switch to turn off check for
> Change-Id
>
> On Tue, 2016-03-01 at 18:37 +0000, Pottratz, Dwane wrote:
> >
> > A commit hook for the Gerrit code review servers inserts change
> > identifiers. These identifiers are noise in the context of the
> > upstream kernel. However, they are needed in most development
> > environments and the error needs to be ignored for static analysis
> > tools.
> btw: another way to do this is to use the --ignore <foo-list> option.
>
> $ ./scripts/checkpatch.pl --ignore gerrit_change_id <patch>
>