Re: [PATCH 2/4] regulator: core: Add support for active-discharge configuration

From: Mark Brown
Date: Tue Mar 01 2016 - 22:13:56 EST


On Wed, Mar 02, 2016 at 07:31:40AM +0530, Laxman Dewangan wrote:

> Yaah, I agree.
> I had other option to use 0 as default, 1 as disable and 2 as enable. but
> generally for disable, we use 0 and for enable 1 and that's why I went to
> -1,0,1 approach.

> Will it be fine to have this as
> 0: Default i..e do not change.
> 1: disable.
> 2: Enable.

I'd suggest defining an enum here with default explicitly set to 0 but
yes.

Attachment: signature.asc
Description: PGP signature