Re: [PATCH] ASoC: intel: remove unused variable

From: Sudip Mukherjee
Date: Wed Mar 02 2016 - 08:08:09 EST


On Wed, Mar 02, 2016 at 12:27:09PM +0000, One Thousand Gnomes wrote:
> On Wed, 2 Mar 2016 11:56:28 +0530
> Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> wrote:
>
> > On Wed, Mar 02, 2016 at 10:02:23AM +0900, Mark Brown wrote:
> > > On Tue, Mar 01, 2016 at 11:19:27AM +0530, Sudip Mukherjee wrote:
> > >
> > > > Can i not keep using my gmail as my From: ?
> > > > The advantage of using gmail as my From: is that the discussion and all
> > > > threads related to my patches will be in the same place even if my work
> > > > email is changed.
> > >
> > > That's fine (I'm doing something similar), just use that as your signoff
> > > address then.
> > >
> > > > And AFAIK, the From: name and the Signed-off-by: name should match else
> > > > the tools used by Greg and others to generate the stats will break.
> > >
> > > I don't understand - what I'm pointing out here is that they do not
> > > match?
> >
> > Now I am confused. :(
> > My From: is Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxxx>
> > and my Signed-off-by: is Sudip Mukherjee <sudip.mukherjee@xxxxxxxxxxxxxxx>
> >
> > My From name and Signed-off name matches. But my emails donot match.
>
> Which is fine - unless you are submitting patches to Mark 8). I also
> usually split my email address and GregKH doesn't seem to mind at all.

Well, Mark has also accepted many patches from me which has same name
but different email addresses.

>
> The other option I suppose would be to put both addresses in the signed
> off by sequence, but that probably causes confusion

yes, maybe. I believe I should be responsible for the patches which I
have sent and any regression or problem because of any of my patch
should come to me. If I just use my corporate email address in both my
From: and Signed-off: then I will not be reachable after I change job.

regards
sudip