Re: [PATCH] ASoC: intel: remove unused variable

From: Mark Brown
Date: Wed Mar 02 2016 - 08:20:45 EST


On Wed, Mar 02, 2016 at 12:27:09PM +0000, One Thousand Gnomes wrote:
> Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> wrote:

> > My From: is Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxxx>
> > and my Signed-off-by: is Sudip Mukherjee <sudip.mukherjee@xxxxxxxxxxxxxxx>

> > My From name and Signed-off name matches. But my emails donot match.

> Which is fine - unless you are submitting patches to Mark 8). I also
> usually split my email address and GregKH doesn't seem to mind at all.

I usually end up applying but I don't like having to think about it and
normally only for people I recognise both addresses and all the names
for - there's a lot of places that can fall over. I've noticed an
increase in the number of people missing out signoffs recently for some
reason so anything that looks like a non-author message is a red flag.

> The other option I suppose would be to put both addresses in the signed
> off by sequence, but that probably causes confusion

The other option is to just not use the work address if you don't want
to use it (that's what I do).

Attachment: signature.asc
Description: PGP signature