Re: [PATCH 03/17] dt-bindings: Add PLX Technology RPS IRQ Controller bindings

From: Neil Armstrong
Date: Thu Mar 03 2016 - 09:57:26 EST


Hi Andrew,

On 03/03/2016 03:53 PM, Andrew Lunn wrote:
>
>> +- compatible: Should be "plxtech,nas782x-rps"
>
> Hi Neil
>
> It would be nice to be consistent with the naming.
The compatible is now oxsemi,os810se-rps-irq which is consistent with the timer.

>
> Maybe also the filename of the driver itself should be changed. You
> had an interesting sorting problem in the Makefile, which a consistent
> name would help with.
Yes, I will add -irq to the driver name and _IRQ to the config name.

>
> Andrew
>
Thanks,
Neil