Re: [PATCH] stmmac: fix noderef.cocci warnings

[David Miller]

From: Alexandre Torgue <alexandre.torgue@xxxxxx>
Date: Fri, 4 Mar 2016 13:45:40 +0100

> Hi,
> 
> On 03/03/2016 02:55 AM, kbuild test robot wrote:
>> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:115:15-21:
>> ERROR: application of sizeof to pointer
>>
>>   sizeof when applied to a pointer typed expression gives the size of
>>   the pointer
>>
>> Generated by: scripts/coccinelle/misc/noderef.cocci
>>
>> CC: Giuseppe Cavallaro <peppe.cavallaro@xxxxxx>
>> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
>> ---
>>
>>   stmmac_platform.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> @@ -112,7 +112,7 @@ static struct stmmac_axi *stmmac_axi_set
>>   	if (!np)
>>   		return NULL;
>>
>> -	axi = kzalloc(sizeof(axi), GFP_KERNEL);
>> +	axi = kzalloc(sizeof(*axi), GFP_KERNEL);
>>   	if (!axi)
>>   		return ERR_PTR(-ENOMEM);
>>
>>
> 
> 
> Thanks.
> You can add my Acked-by: Alexandre Torgue <alexandre.torgue@xxxxxx>

Don't do this.

Automated tools look for Acked-by: tags in replies to patch postings
in a certain way, so you must provide you Acked-by: on the first
column of a line in order for it to be picked up properly by those
tools.