RE: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

From: Zhang, Rui
Date: Mon Mar 07 2016 - 03:55:54 EST


For the soc thermal driver changes, you'd better cc Eduardo at the same time so that he can include this in his soc-thermal pull request.
Surely I can queue this for 4.6 if Eduardo miss this.

Thanks,
rui

> -----Original Message-----
> From: Wei Ni [mailto:wni@xxxxxxxxxx]
> Sent: Monday, March 07, 2016 4:26 PM
> To: thierry.reding@xxxxxxxxx; Zhang, Rui <rui.zhang@xxxxxxxxx>;
> mikko.perttunen@xxxxxxxx
> Cc: Matt Longnecker <mlongnecker@xxxxxxxxxx>; swarren@xxxxxxxxxxxxx;
> linux-tegra@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature
> Importance: High
>
> Hi, Rui and Thierry
> Could you please take a look at this patch?
>
> Thanks.
> Wei.
>
> On 2016å03æ03æ 08:08, Matt Longnecker wrote:
> >
> >
> > On 03/01/2016 11:40 PM, Wei Ni wrote:
> >> >diff --git a/drivers/thermal/tegra_soctherm.c
> b/drivers/thermal/tegra_soctherm.c
> >> >index 74ea5765938b..136975220c92 100644
> >> >--- a/drivers/thermal/tegra_soctherm.c
> >> >+++ b/drivers/thermal/tegra_soctherm.c
> >> >@@ -57,7 +57,7 @@
> >> > #define READBACK_VALUE_MASK 0xff00
> >> > #define READBACK_VALUE_SHIFT 8
> >> > #define READBACK_ADD_HALF BIT(7)
> >> >-#define READBACK_NEGATE BIT(1)
> >> >+#define READBACK_NEGATE BIT(0)
> > I confirm that this change is technically correct. It fixes a bug.