Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

From: Jiri Kosina
Date: Mon Mar 07 2016 - 12:24:31 EST


On Mon, 7 Mar 2016, Sedat Dilek wrote:

> Did someone look at the next/follow-ups in this thread?
> For example: D6629 "x86: Emit LAHF/SAHF instead of PUSHF/POPF" [2]?

Using LAHF/SAHF would "solve" it, as IF is at bit #9. The question is
whether they need to play with flags here at all.

On Mon, 7 Mar 2016, Sedat Dilek wrote:

> So, if Clang is producing wrong X86 code here, is it possible to turn
> interrupts on/off manually? But, hmm that affects other places as well
> in the Linux sources, so.

This issue needs to be handled in the compiler.

--
Jiri Kosina
SUSE Labs