Re: [PATCH 1/3] mm, compaction: change COMPACT_ constants into enum
From: Vlastimil Babka
Date: Tue Mar 08 2016 - 09:19:40 EST
On 03/08/2016 02:42 PM, Michal Hocko wrote:
> From: Michal Hocko <mhocko@xxxxxxxx>
> compaction code is doing weird dances between
> COMPACT_FOO -> int -> unsigned long
> but there doesn't seem to be any reason for that. All functions which
I vaguely recall trying this once and running into header dependency
hell. But maybe it was something a bit different and involved storing a
value in struct compact_control.
> return/use one of those constants are not expecting any other value
> so it really makes sense to define an enum for them and make it clear
> that no other values are expected.
> This is a pure cleanup and shouldn't introduce any functional changes.
> Signed-off-by: Michal Hocko <mhocko@xxxxxxxx>
Acked-by: Vlastimil Babka <vbabka@xxxxxxx>