Re: [PATCH 3/5] gpio: of: Return error if gpio hog configuration failed
From: Thierry Reding
Date: Tue Mar 08 2016 - 09:23:39 EST
On Tue, Mar 08, 2016 at 05:32:06PM +0530, Laxman Dewangan wrote:
> If GPIO hog configuration failed while adding OF based
> gpiochip() then return the error instead of ignoring it.
> This helps of properly handling the gpio driver dependency.
> When adding the gpio hog nodes for NVIDIA's Tegra210 platforms,
> the gpio_hogd() fails with EPROBE_DEFER because pinctrl is not
> ready at this time and gpio_request() for Tegra GPIO driver
> returns error. The error was not causing the Tegra GPIO driver
> to fail as the error was getting ignored.
> Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
> Cc: Benoit Parrot <bparrot@xxxxxx>
> Cc: Alexandre Courbot <acourbot@xxxxxxxxxx>
> drivers/gpio/gpiolib-of.c | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
Description: PGP signature