Re: [PATCH 3/8] drivers/pinctrl: make meson/pinctrl-meson.c explicitly non-modular
From: Linus Walleij
Date: Tue Mar 08 2016 - 22:04:09 EST
On Tue, Mar 1, 2016 at 3:48 AM, Paul Gortmaker
> The Kconfig currently controlling compilation of this code is:
> drivers/pinctrl/Kconfig:config PINCTRL_MESON
> drivers/pinctrl/Kconfig: bool
> ...meaning that it currently is not being built as a module by anyone.
> Lets remove the couple traces of modularity so that when reading the
> driver there is no doubt it is builtin-only.
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
> We don't replace module.h with init.h since the file already has that.
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Beniamino Galvani <b.galvani@xxxxxxxxx>
> Cc: Carlo Caione <carlo@xxxxxxxxxxxx>
> Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> Cc: Antoine Tenart <antoine.tenart@xxxxxxxxxxxxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>