Re: [PATCH v3 1/9] clocksource: arm_arch_timer: Gather KVM specific information in a structure

From: Julien Grall
Date: Wed Mar 09 2016 - 00:35:41 EST


Hi Christoffer,

On 09/03/2016 10:23, Christoffer Dall wrote:
On Tue, Mar 08, 2016 at 11:29:25AM +0000, Julien Grall wrote:
-static struct timecounter timecounter;
+static struct arch_timer_kvm_info arch_timer_kvm_info;
+
+struct arch_timer_kvm_info *arch_timer_get_kvm_info(void)

borderline bikeshedding question:

does it make sense that the info the arch timer code exports is labeled
to be kvm-specific? In other words, could we imagine another subsystem
using this timer info some time and is there a more generic term that
would be more appropriate?

I can't see any other usage. I would keep the function name KVM specific until someone really need similar information.

Cheers,

--
Julien Grall