Re: [PATCH 09/11] tools/objtool: Copy hashtable.h into tools directory
From: Ingo Molnar
Date: Wed Mar 09 2016 - 04:48:15 EST
* Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> Copy hashtable.h from include/linux/tools.h. It's needed by objtool in
> the next patch in the series.
> Add some includes that it needs, and remove references to
> kernel-specific features like RCU and __read_mostly.
> Also change some if its dependency headers' includes to use quotes
> instead of brackets so gcc can find them.
> Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> tools/include/asm-generic/bitops/__fls.h | 2 +-
> tools/include/asm-generic/bitops/fls.h | 2 +-
> tools/include/asm-generic/bitops/fls64.h | 2 +-
> tools/include/linux/hashtable.h | 152 +++++++++++++++++++++++++++++++
> 4 files changed, 155 insertions(+), 3 deletions(-)
So it would be nice to also add a build time warning if the 'upstream' copy of
hashtable.h deviates from the tooling file.
Just like you are already doing it for other files:
objtool/Makefile: diff -I'^#include' arch/x86/insn/insn.c ../../arch/x86/lib/insn.c >/dev/null && \
Btw., eventually we might want to factor out such duplication into a single place
in tools/lib/ or so, to only have a 'master copy' (upstream kernel source), and
the tooling copy.