Re: [PATCH v2 4/5] mm, kswapd: replace kswapd compaction with waking up kcompactd
From: Vlastimil Babka
Date: Wed Mar 09 2016 - 08:52:20 EST
On 03/05/2016 12:25 AM, Andrew Morton wrote:
> On Wed, 2 Mar 2016 16:22:43 +0100 Vlastimil Babka <vbabka@xxxxxxx> wrote:
>> On 03/02/2016 03:59 PM, Joonsoo Kim wrote:
>>> 2016-03-02 23:40 GMT+09:00 Vlastimil Babka <vbabka@xxxxxxx>:
>>>> On 03/02/2016 03:22 PM, Joonsoo Kim wrote:
>>>> So I understand that patch 5 would be just about this?
>>>> - if (compaction_restarting(zone, cc->order) && !current_is_kcompactd())
>>>> + if (compaction_restarting(zone, cc->order))
>>> Yeah, you understand correctly. :)
>>>> I'm more inclined to fold it in that case.
>>> Patch would be just simple, but, I guess it would cause some difference
>>> in test result. But, I'm okay for folding.
>> Thanks. Andrew, should I send now patch folding patch 4/5 and 5/5 with
>> all the accumulated fixlets (including those I sent earlier today) and
>> combined changelog, or do you want to apply the new fixlets separately
>> first and let them sit for a week or so? In any case, sorry for the churn.
> Did I get everything?
Please replace the following three:
With the squashed one below (had to mangle the changelog nontrivially).
This is after discussion with Joonsoo. It was perhaps better separately for
review, but functionality-wise the first patch leaves things somewhat
weird without the third patch.