Re: [RESPIN 1/6] dt-bindings: EXYNOS: Add exynos-srom device tree binding
Date: Thu Mar 10 2016 - 21:38:24 EST
On Saturday 05 March 2016 11:48 AM, pankaj.dubey wrote:
> On Wednesday 02 March 2016 11:23 PM, Rob Herring wrote:
>> On Thu, Feb 25, 2016 at 02:03:37PM +0530, Pankaj Dubey wrote:
>>> This patch adds exynos-srom binding information for SROM Controller
>>> driver on Exynos SoCs.
>>> CC: Rob Herring <robh+dt@xxxxxxxxxx>
>>> CC: Mark Rutland <mark.rutland@xxxxxxx>
>>> CC: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx>
>>> CC: devicetree@xxxxxxxxxxxxxxx
>>> Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx>
>>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
>>> Signed-off-by: Kukjin Kim <kgene@xxxxxxxxxx>
>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
>>> .../devicetree/bindings/memory-controllers/exynos-srom.txt | 12 ++++++++++++
>>> 1 file changed, 12 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt
>>> diff --git a/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt b/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt
>>> new file mode 100644
>>> index 0000000..33886d5
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt
>>> @@ -0,0 +1,12 @@
>>> +SAMSUNG Exynos SoCs SROM Controller driver.
>>> +Required properties:
>>> +- compatible : Should contain "samsung,exynos-srom".
>> There should be SoC specific compatible strings in addition to this.
> I do not understood need of additional SoC specific compatible here. As
> of now all SoCs having SROM can work with exynos specific common
> compatible. Do you see any issues if we do not have SoC specific
> compatible here.