Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines.
From: Mika Westerberg
Date: Fri Mar 11 2016 - 05:58:56 EST
On Thu, Mar 10, 2016 at 09:57:09PM +0100, Rafael J. Wysocki wrote:
> > It doesn't seem to do any runtime PM,
> > I do wonder if pcieport should be doing it's own runtime PM handling,
> > but that is a
> > larger task than I'm thinking to tackle here.
> PCIe ports don't do PM - yet. Mika has posted a series of patches to implement
> that, however, that are waiting for comments now:
> > Maybe I should be doing
> > pci_set_power_state(pdev->bus->self, PCI_D3cold) ? I'm not really sure.
> Using pci_set_power_state() would be more appropriate IMO, but you can get
> to the bridge via dev->parent too, can't you?
> In any case, it looks like you and Mika need to talk. :-)
When the vga_switcheroo device gets runtime suspended (with the above
runtime PM patchs for PCIe root ports) the root port should also be
runtime suspended by the PM core. I don't think there is a need to call
any pci_set_power_state() in this driver but maybe I'm missing