Re: [PATCH 0/6] arc_emac: fixes the emac issues oand cleanup emac drivers

From: Caesar Wang
Date: Sat Mar 12 2016 - 23:05:15 EST

å 2016å03æ12æ 02:46, Sergei Shtylyov åé:

On 03/11/2016 05:48 PM, Caesar Wang wrote:


Hi Rob, David:
PATCH[1/6-2/6]: ====>
net: arc_emac: make the rockchip emac document more compatible
net: arc_emac: add phy-reset-* are optional for device tree

The patches change the rockchip emac document for more compatible and
Add the phy-reset-* property for document.

This patch adds the following property for arc_emac.

phy-reset-* include the following:
1) phy-reset-gpios:
The phy-reset-gpios is an optional property for arc emac device tree boot.
Change the binding document to match the driver code.

2) phy-reset-duration:
Different boards may require different phy reset duration. Add property
phy-reset-duration for device tree probe, so that the boards that need
a longer reset duration can specify it in their device tree.

3) phy-reset-active-high:
We need that for a custom hardware that needs the reverse reset sequence.

Why not infer this from the "phy-reset-gpios" prop?

phy-reset-active-high : If present then the reset sequence using the GPIO
specified in the "phy-reset-gpios" property is reversed (H=reset state,
L=operation state).

Referring to your own suggested bindings isn't an answer. If the driver that you're copying from here (fec) had a reason to handle the GPIO sense with the help of an extra prop (legacy code), it doesn't mean your new driver needs to mimic this as well, AFAIU...

I know your suggestion is a fair request.

Oh, that copy from the 'freescale/fec_main.c' ....

So, The exist way was old and unwise in mainline. :(

wxt@nb:~/kernel/drivers/net/ethernet$ ag reset-gpios
1427: gpio = of_get_named_gpio_flags(spi->dev.of_node, "reset-gpios",

787: phy_reset = of_get_named_gpio(np, "phy-reset-gpios", 0);
797: dev_err(dev, "failed to get phy-reset-gpios: %d\n", err);

784: phy_reset = of_get_named_gpio(np, "phy-reset-gpios", 0);
794: dev_err(dev, "failed to get phy-reset-gpios: %d\n", err);

1451: reset_gpios = of_get_named_gpio_flags(dev->of_node, "reset-gpios", 0,

3206: phy_reset = of_get_named_gpio(np, "phy-reset-gpios", 0);
3216: dev_err(&pdev->dev, "failed to get phy-reset-gpios: %d\n", err);

2958: int gpio = of_get_named_gpio(phy_node, "reset-gpios", 0);


Anyway, I will update it with your suggestion.





MBR, Sergei

Linux-rockchip mailing list