Re: [RFC PATCH net-next 3/3] net: dsa: refine netdev event notifier

From: Vivien Didelot
Date: Sun Mar 13 2016 - 09:39:15 EST


Hi Ido,

Ido Schimmel <idosch@xxxxxxxxxxxx> writes:

>>+ case NETDEV_PRECHANGEUPPER:
>
> Why do you need this here? It seems you are always ignoring it in
> dsa_slave_port_upper_event()? Probably better to introduce it when you
> actually need it.
>
> Other than that, it looks good to me.

I've prepare a real v1 without this switch case locally, I'll send it in
a few moment unless there are other comments.

Thanks Ido!
Vivien