Re: [lkp] [namei] fda89e6574: kernel BUG at fs/namei.c:679!

[Al Viro]

On Mon, Mar 14, 2016 at 08:48:26AM +0800, kernel test robot wrote:
> FYI, we noticed the below changes on
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.lookups
> commit fda89e65743179d09e55bc6c265d06fa5efa8803 ("namei: untanlge lookup_fast()")

Could you check if the diff below fixes it?

diff --git a/fs/namei.c b/fs/namei.c
index 35b10fa..428a34f 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -1563,6 +1563,7 @@ static int lookup_fast(struct nameidata *nd,
 					dput(dentry);
 					return status;
 				}
+				goto l;
 			}
 		}
 		/*
@@ -1590,6 +1591,7 @@ static int lookup_fast(struct nameidata *nd,
 				return status;
 			}
 		}
+l:
 		if (unlikely(d_is_negative(dentry))) {
 			dput(dentry);
 			return -ENOENT;