Re: [PATCH 02/22] ncr5380: Remove FLAG_NO_PSEUDO_DMA where possible

From: Hannes Reinecke
Date: Mon Mar 14 2016 - 03:22:08 EST


On 03/14/2016 05:27 AM, Finn Thain wrote:
> Drivers that define PSEUDO_DMA also define NCR5380_dma_xfer_len.
> The core driver must call NCR5380_dma_xfer_len which means
> FLAG_NO_PSEUDO_DMA can be eradicated from the core driver.
>
> dmx3191d doesn't define PSEUDO_DMA and has no use for FLAG_NO_PSEUDO_DMA,
> so remove it there also.
>
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
>
> ---
> drivers/scsi/NCR5380.c | 3 +--
> drivers/scsi/dmx3191d.c | 2 +-
> drivers/scsi/g_NCR5380.c | 7 ++++++-
> drivers/scsi/g_NCR5380.h | 2 +-
> drivers/scsi/mac_scsi.c | 15 ++++++++++++++-
> 5 files changed, 23 insertions(+), 6 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)