Re: [PATCH 06/22] ncr5380: Remove PSEUDO_DMA macro

From: Hannes Reinecke
Date: Mon Mar 14 2016 - 03:28:22 EST


On 03/14/2016 05:27 AM, Finn Thain wrote:
> For those wrapper drivers which only implement Programmed IO, have
> NCR5380_dma_xfer_len() evaluate to zero. That allows PDMA to be easily
> disabled at run-time and so the PSEUDO_DMA macro is no longer needed.
>
> Also remove the spin counters used for debugging pseudo DMA drivers.
>
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
>
> ---
> drivers/scsi/NCR5380.c | 32 +-------------------------------
> drivers/scsi/NCR5380.h | 4 ----
> drivers/scsi/arm/cumana_1.c | 2 --
> drivers/scsi/arm/oak.c | 3 +--
> drivers/scsi/dmx3191d.c | 4 ++++
> drivers/scsi/dtc.c | 7 -------
> drivers/scsi/dtc.h | 2 --
> drivers/scsi/g_NCR5380.c | 1 -
> drivers/scsi/g_NCR5380.h | 1 -
> drivers/scsi/mac_scsi.c | 10 ----------
> drivers/scsi/pas16.c | 10 ----------
> drivers/scsi/pas16.h | 2 --
> drivers/scsi/t128.c | 4 ----
> drivers/scsi/t128.h | 2 --
> 14 files changed, 6 insertions(+), 78 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)